From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.22-rc5] libata: be less verbose about hpa
Date: Mon, 25 Jun 2007 21:12:46 +0900 [thread overview]
Message-ID: <467FB13E.1080108@gmail.com> (raw)
In-Reply-To: <20070625131259.62d7b79f@the-village.bc.nu>
Alan Cox wrote:
> On Mon, 25 Jun 2007 20:45:54 +0900
> Tejun Heo <htejun@gmail.com> wrote:
>
>> There's no reason to print out hpa related messages when HPA is not
>> active. Kill the unconditional message and add a warning message
>> which is printed if HPA size is smaller than the current size.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> Acked-by: Alan Cox <alan@redhat.com>
>
> (Should it be a dprintk instead of vanish though ?)
I thought about doing KERN_DEBUG but we have printks for both hpa >
current and hpa < current, so if no message is printed hpa == current
and the current sectors is printed in the next line anyway, so I think
we can just drop it.
--
tejun
next prev parent reply other threads:[~2007-06-25 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 11:45 [PATCH 2.6.22-rc5] libata: be less verbose about hpa Tejun Heo
2007-06-25 12:12 ` Alan Cox
2007-06-25 12:12 ` Tejun Heo [this message]
2007-06-27 6:45 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467FB13E.1080108@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.