From: Patrick McHardy <kaber@trash.net>
To: Stephane Chazelas <stephane@artesyncp.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [bug+patch] SCTP and chunk types over 0x1f
Date: Mon, 25 Jun 2007 15:58:43 +0200 [thread overview]
Message-ID: <467FCA13.5050401@trash.net> (raw)
In-Reply-To: <20070625135040.GV20467@artesyncp.com>
Stephane Chazelas wrote:
> On Mon, Jun 25, 2007 at 03:40:27PM +0200, Patrick McHardy wrote:
>
>>>- the chunkmap, which is a bitmap of which chunk is selected is
>>> defined as an array of 256 / 4 u32s, that is 256 * 8 bits,
>>> 256 / 32 is enough (256 bits).
>>
>>
>>We can't change that since it breaks userspace compatibility.
>
>
> I see. But that doesn't look very tidy. Maybe some transitional
> code with a warning in both the kernel and iptables?
We could add a new revision, but still need to keep the old
structure for old binaries. Doesn't seem worth it for this
minor waste of space.
>>Could you please resend without the chunkmap changes? Thanks.
>
>
> That's just a matter of removing the first change:
Does it stay completely compatible (modulo fixed bugs) then?
next prev parent reply other threads:[~2007-06-25 13:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 15:19 [bug+patch] SCTP and chunk types over 0x1f Stephane Chazelas
2007-06-25 13:40 ` Patrick McHardy
2007-06-25 13:50 ` Stephane Chazelas
2007-06-25 13:58 ` Patrick McHardy [this message]
2007-06-25 14:08 ` Stephane Chazelas
2007-06-25 14:15 ` Stephane Chazelas
2007-06-25 14:42 ` Patrick McHardy
2007-06-25 15:07 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467FCA13.5050401@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=stephane@artesyncp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.