From: Michal Schmidt <mschmidt@redhat.com>
To: Dan Williams <dcbw@redhat.com>
Cc: Matteo Croce <rootkit85@yahoo.it>, linux-wireless@vger.kernel.org
Subject: Re: airo
Date: Mon, 25 Jun 2007 17:48:14 +0200 [thread overview]
Message-ID: <467FE3BE.5040206@redhat.com> (raw)
In-Reply-To: <467FDC79.6090102@redhat.com>
Michal Schmidt wrote:
> Dan Williams wrote:
>> Wow, that's somewhat ugly. Do other drivers just not have this problem,
>> or have they worked around it in similar or different ways? Just trying
>> to understand if the scope of the issue is wider than just airo.
>
> For instance, drivers/net/wireless/atmel.c looks very similar, so I
> guess it has the same race. With airo the race is just more visible,
> because of all the long sleeps it does between getting the name with
> dev_alloc_name and finally registering it.
>
> eepro100.c takes rtnl_lock to avoid the issue. So does ns83820.c - it
> has a big comment about how ugly it is.
A cleaner way would be to do most of the initialization later, from the
->open() method. I'll explore how workable this approach would be.
Michal
next prev parent reply other threads:[~2007-06-25 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200706061903.13228.rootkit85@yahoo.it>
[not found] ` <46693003.8090406@redhat.com>
[not found] ` <200706091519.29319.rootkit85@yahoo.it>
2007-06-09 16:16 ` airo Matteo Croce
2007-06-25 14:38 ` airo Michal Schmidt
2007-06-25 15:05 ` airo Dan Williams
2007-06-25 15:17 ` airo Michal Schmidt
2007-06-25 15:48 ` Michal Schmidt [this message]
2007-06-25 19:27 ` airo Matteo Croce
2007-06-25 19:50 ` airo Larry Finger
2007-06-25 21:10 ` airo Dan Williams
2007-06-27 1:58 ` airo Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467FE3BE.5040206@redhat.com \
--to=mschmidt@redhat.com \
--cc=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rootkit85@yahoo.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.