From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 02/10] nf_conntrack: Introduces a extension infrastructure Date: Mon, 25 Jun 2007 20:16:31 +0200 Message-ID: <4680067F.20204@trash.net> References: <200706251721.l5PHLQ8x023174@toshiba.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org To: Yasuyuki KOZAKAI Return-path: In-Reply-To: <200706251721.l5PHLQ8x023174@toshiba.co.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Yasuyuki KOZAKAI wrote: > Old space allocator of conntrack had problems about extensibility. > - It required slab cache per combination of extensions. > - It expected what extensions would be assigned, but it was impossible > to expect that completely, then we allocated bigger memory object than > really required. > - It needed to search helper twice due to lock issue. > > Now basic informations of a connection are stored in 'struct nf_conn'. > And a storage for extension (helper, NAT) is allocated by kmalloc. > > Signed-off-by: Yasuyuki Kozakai Also applied, thanks.