From: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
To: sct@redhat.com, akpm@linux-foundation.org, adilger@clusterfs.com
Cc: linux-ext4@vger.kernel.org
Subject: [Patch] mistaken ext4_inode_bitmap for ext4_block_bitmap
Date: Tue, 26 Jun 2007 13:24:10 +0900 [thread overview]
Message-ID: <468094EA.60609@jp.fujitsu.com> (raw)
Hi.
I found an obvious mistake in ext4_new_blocks().
I made a fix patch for it.
Please confirm it.
This patch is for 2.6.22-rc5.
---
In ext4_new_blocks(), one of two ext4_block_bitmap() calls should be ext4_inode_bitmap() call.
It is not harmful in normal processing, but it should be fixed.
Signed-off-by: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
---
fs/ext4/balloc.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.22-rc5.org/fs/ext4/balloc.c 2007-06-17 11:09:12.000000000 +0900
+++ linux-2.6.22-rc5/fs/ext4/balloc.c 2007-06-22 13:50:22.000000000 +0900
@@ -1585,7 +1585,7 @@ allocated:
ret_block = grp_alloc_blk + ext4_group_first_block_no(sb, group_no);
if (in_range(ext4_block_bitmap(sb, gdp), ret_block, num) ||
- in_range(ext4_block_bitmap(sb, gdp), ret_block, num) ||
+ in_range(ext4_inode_bitmap(sb, gdp), ret_block, num) ||
in_range(ret_block, ext4_inode_table(sb, gdp),
EXT4_SB(sb)->s_itb_per_group) ||
in_range(ret_block + num - 1, ext4_inode_table(sb, gdp),
reply other threads:[~2007-06-26 4:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468094EA.60609@jp.fujitsu.com \
--to=toshi.okajima@jp.fujitsu.com \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.