From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
netfilter-devel@lists.netfilter.org,
Amin Azez <azez@ufomechanic.net>,
Jaime Nebrera <jnebrera@eneotecnologia.com>
Subject: Re: VLAN match within iptables
Date: Tue, 26 Jun 2007 12:09:16 +0200 [thread overview]
Message-ID: <4680E5CC.8070807@trash.net> (raw)
In-Reply-To: <4680E3D7.6020401@netfilter.org>
Pablo Neira Ayuso wrote:
> Since you have to apply that patch to your kernel anyway, I suggest you
> to apply the u32 patch instead (it is scheduled for 2.6.23 IIRC).
I don't think that will work, it can't be used to match on data
before skb->data since the offset can only be positive.
Jan, I just noticed the length checks are insufficient, very
large positives offsets will lead to integer overflow and
probably trigger the BUG afterwards. Another thing I missed
before is that you should never do:
BUG_ON(expression with side-effects);
since some people disable BUG_ON.
Can you send a fix for this please?
next prev parent reply other threads:[~2007-06-26 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 9:22 VLAN match within iptables Jaime Nebrera
2007-06-26 9:34 ` Jan Engelhardt
2007-06-26 9:38 ` Patrick McHardy
2007-06-26 9:41 ` Jan Engelhardt
2007-06-26 10:00 ` Pablo Neira Ayuso
2007-06-26 10:09 ` Patrick McHardy [this message]
2007-06-26 12:38 ` Jan Engelhardt
2007-06-26 12:50 ` Patrick McHardy
2007-06-26 13:12 ` xt_u32 20070626 (Re: VLAN match within iptables) Jan Engelhardt
2007-06-26 13:13 ` xt_u32 20070626 (iptables part) Jan Engelhardt
2007-06-26 16:49 ` Patrick McHardy
2007-06-26 13:19 ` xt_u32 20070626 (Re: VLAN match within iptables) Patrick McHardy
2007-06-26 13:35 ` Jan Engelhardt
2007-06-26 13:36 ` Patrick McHardy
2007-06-26 14:05 ` Jan Engelhardt
2007-06-26 14:06 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4680E5CC.8070807@trash.net \
--to=kaber@trash.net \
--cc=azez@ufomechanic.net \
--cc=jengelh@computergmbh.de \
--cc=jnebrera@eneotecnologia.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.