From: Valerie Clement <valerie.clement@bull.net>
To: Girish Shilamkar <girish@clusterfs.com>
Cc: Alex Tomas <alex@clusterfs.com>,
Andreas Dilger <adilger@clusterfs.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: performance testing
Date: Tue, 26 Jun 2007 13:03:15 +0200 [thread overview]
Message-ID: <4680F273.3080809@bull.net> (raw)
In-Reply-To: <1182854211.3041.10.camel@dhcp7.linsyssoft.com>
Girish Shilamkar wrote:
> On Tue, 2007-06-26 at 11:48 +0200, Valerie Clement wrote:
>> Shouldn't it be :
>>
>> struct commit_header *tmp = (struct commit_header*)(bh->b_data + i);
>>
> Ohhh, yes you are right. This is the correct thing to do.
> This patch which is been used has some endian-ness bugs. I had sent an
> updated patch for 2.6.22-rc5 on
> 19 June. I think we should be using the updated patch else it may break
> on big-endian machines.
> Even the updated patch has this bug i.e "struct commit_header *tmp
> =...."
>
> Thanks,
> Girish.
>
Hi Girish,
I made the change on my system and tested it. Good news, everything
seems to work well now. Could you please make and post the patch?
Thanks,
Valérie
next prev parent reply other threads:[~2007-06-26 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <467BE4C0.2020203@bull.net>
[not found] ` <1182541578.9939.3.camel@localhost.localdomain>
[not found] ` <467C99F5.6060603@clusterfs.com>
[not found] ` <1182755567.4067.1.camel@localhost.localdomain>
[not found] ` <467FE8A5.4030508@bull.net>
[not found] ` <467FEAF7.7060902@clusterfs.com>
[not found] ` <4680CE9B.1030602@bull.net>
2007-06-26 9:48 ` performance testing Valerie Clement
2007-06-26 10:36 ` Girish Shilamkar
2007-06-26 11:03 ` Valerie Clement [this message]
2014-09-17 8:48 Performance testing Jan Tulak
2014-09-17 9:36 ` Dmitry Monakhov
2014-09-25 15:08 ` Jan Tulak
2014-09-18 0:36 ` Dave Chinner
2014-09-25 15:03 ` Jan Tulak
2014-09-27 0:47 ` Dave Chinner
2014-09-29 16:07 ` Jan Tulak
2014-10-25 17:10 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4680F273.3080809@bull.net \
--to=valerie.clement@bull.net \
--cc=adilger@clusterfs.com \
--cc=alex@clusterfs.com \
--cc=girish@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.