From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.22-rc5] libata: kill non-sense warning message
Date: Wed, 27 Jun 2007 02:45:16 -0400 [thread overview]
Message-ID: <4682077C.8060702@garzik.org> (raw)
In-Reply-To: <467FB0E1.206@gmail.com>
Tejun Heo wrote:
> prereset() is now allowed to set flag for unsupported reset method.
> EH layer is responsible for selecting the fallback. Remove non-sense
> warning message.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index d807098..376f004 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1665,8 +1665,6 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
>
> /* did prereset() screw up? if so, fix up to avoid oopsing */
> if (!reset) {
> - ata_port_printk(ap, KERN_ERR, "BUG: prereset() requested "
> - "invalid reset type\n");
> if (softreset)
> reset = softreset;
applied
prev parent reply other threads:[~2007-06-27 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 12:11 [PATCH 2.6.22-rc5] libata: kill non-sense warning message Tejun Heo
2007-06-27 6:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4682077C.8060702@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.