From: "H. Peter Anvin" <hpa@zytor.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Matthew Wilcox <matthew@wil.cx>,
Matt Domsch <Matt_Domsch@dell.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>,
gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: pci.h stubs
Date: Wed, 27 Jun 2007 12:41:41 -0400 [thread overview]
Message-ID: <46829345.1000607@zytor.com> (raw)
In-Reply-To: <20070627145500.2e66fd49@the-village.bc.nu>
Alan Cox wrote:
> On Wed, 27 Jun 2007 05:30:48 -0600
> Matthew Wilcox <matthew@wil.cx> wrote:
>
>> On Tue, Jun 26, 2007 at 09:45:05PM -0500, Matt Domsch wrote:
>>> On Tue, Jun 26, 2007 at 01:26:22PM -0700, Randy Dunlap wrote:
>>>> ERROR: "pci_get_bus_and_slot" [drivers/firmware/edd.ko] undefined!
>>> It should be stubbed, in include/linux/pci.h where all the other PCI
>>> functions are stubbed for the !CONFIG_PCI case.
>> pci_get_bus_and_slot() shouldn't be used because it fails to work on
>> systems with multiple domains. pci_get_slot() avoids this problem (and
>> is much faster too).
>
> But requires you have a bus pointer to hand which is often not the
> case. Do we need pci_get_domain_bus_and_slot() ?
>
Note that EDD has no way of referencing anything but the zero domain
(which is presumably the one which is addressed by I/O ports CF8/CFC on
the BSP.) So in this particular case I would say pci_get_bus_and_slot()
is fine.
-hpa
next prev parent reply other threads:[~2007-06-27 16:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 20:26 EDD build error Randy Dunlap
2007-06-26 22:16 ` Torsten Duwe
2007-06-26 22:33 ` Randy Dunlap
2007-06-26 22:44 ` Torsten Duwe
2007-06-26 23:14 ` Randy Dunlap
[not found] ` <20070627024505.GA30197@humbolt.us.dell.com>
2007-06-27 11:30 ` pci.h stubs (was: EDD build error) Matthew Wilcox
2007-06-27 13:55 ` Alan Cox
2007-06-27 14:03 ` Matthew Wilcox
2007-06-27 14:32 ` Alan Cox
2007-06-27 14:32 ` Matthew Wilcox
2007-06-27 15:07 ` Alan Cox
2007-06-27 16:41 ` H. Peter Anvin [this message]
2007-06-27 16:54 ` pci.h stubs Matthew Wilcox
2007-06-27 17:25 ` Alan Cox
2007-06-27 18:34 ` H. Peter Anvin
2007-06-28 23:04 ` [PATCH] PCI: limit pci_get_bus_and_slot to domain 0 Randy Dunlap
2007-06-28 23:48 ` H. Peter Anvin
2007-06-28 23:25 ` [PATCH] pci.h stubs (for EDD build error) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46829345.1000607@zytor.com \
--to=hpa@zytor.com \
--cc=Matt_Domsch@dell.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.