From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux IDE <linux-ide@vger.kernel.org>
Subject: [PATCH 2.6.22-rc6] libata: remove reading alt_status from ata_hsm_qc_complete()
Date: Thu, 28 Jun 2007 10:05:31 +0800 [thread overview]
Message-ID: <4683176B.3060605@tw.ibm.com> (raw)
In ata_hsm_qc_complete():
Calling ata_altstatus() after the qc is completed might race with next qc. Remove it.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
---
Jeff,
(Sorry for re-submitting this patch so late.)
The unneeded reading of alt_status might cause trouble when another command doing activity like pio data xfer.
After checking, the flush here is leftover/merge damage of ata_pio_block( ) in 2.6.17-rc5:
http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commitdiff;h=bb31a8faa270beafcc51a65880c5564c6b718bd6
We can safely remove it.
--- linux-2.6.22-rc6/drivers/ata/libata-core.c.ori 2007-06-28 09:47:31.000000000 +0800
+++ linux-2.6.22-rc6/drivers/ata/libata-core.c 2007-06-28 09:49:26.000000000 +0800
@@ -4799,8 +4799,6 @@ static void ata_hsm_qc_complete(struct a
} else
ata_qc_complete(qc);
}
-
- ata_altstatus(ap); /* flush */
}
/**
next reply other threads:[~2007-06-28 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 2:05 Albert Lee [this message]
2007-07-02 14:14 ` [PATCH 2.6.22-rc6] libata: remove reading alt_status from ata_hsm_qc_complete() Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4683176B.3060605@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=albertl@mail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.