All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Chapman <jchapman@katalix.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/5 2.6.22-rc6] L2TP: Changes to existing ppp and socket kernel headers for L2TP
Date: Thu, 28 Jun 2007 08:39:57 +0100	[thread overview]
Message-ID: <468365CD.7050803@katalix.com> (raw)
In-Reply-To: <20070627.154848.112982936.davem@davemloft.net>

David Miller wrote:

> This is going to cause problems on compat platforms where
> __u64 is aligned on an 8-byte boundary on the 64-bit
> variant but it is not on the 32-bit cpu variant.
> 
> A way to avoid this is to use the aligned_u64 type from
> linux/types.h which ensures 8-byte alignment on all
> platforms and thus you won't need to provide s compat
> ioctl() handler for your statistics ioctl().

Thanks for the info. I wasn't aware of aligned_u64.

> I'll make this change for you so we don't have to go
> back and forth again just for this.

Thanks!

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development


      reply	other threads:[~2007-06-28  7:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-27 22:20 [PATCH 2/5 2.6.22-rc6] L2TP: Changes to existing ppp and socket kernel headers for L2TP James Chapman
2007-06-27 22:48 ` David Miller
2007-06-28  7:39   ` James Chapman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468365CD.7050803@katalix.com \
    --to=jchapman@katalix.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.