From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 06 Jun 2016 15:06:18 +0200 Subject: [PATCH] drm: sun4i: fix LPAE warnings In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> References: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> Message-ID: <4683820.tGQACgnbJT@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday, June 3, 2016 5:57:31 PM CEST Andre Przywara wrote: > When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns > into a 64-bit type, which causes warnings with some debug printks: > ================= > In file included from > drivers/gpu/drm/sun4i/sun4i_backend.c:13:: > drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer': > drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning: > format '%x' expects argument of type 'unsigned int', but argument 3 has > type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr); > ^ > include/drm/drmP.h:207:34: note: in definition of macro > 'DRM_DEBUG_DRIVER' > drm_ut_debug_printk(__func__, fmt, ##args); \ > ..... > > Use the proper printk format specifier [1] for dma_addr_t which takes > care of those differences. > > Signed-off-by: Andre Przywara > I submitted the same patch a month ago, and it's already in linux-next, I assume it will show up in mainline soon. arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] drm: sun4i: fix LPAE warnings Date: Mon, 06 Jun 2016 15:06:18 +0200 Message-ID: <4683820.tGQACgnbJT@wuerfel> References: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F86E6E1DF for ; Mon, 6 Jun 2016 22:31:53 +0000 (UTC) In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-arm-kernel@lists.infradead.org Cc: Andre Przywara , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Maxime Ripard List-Id: dri-devel@lists.freedesktop.org T24gRnJpZGF5LCBKdW5lIDMsIDIwMTYgNTo1NzozMSBQTSBDRVNUIEFuZHJlIFByenl3YXJhIHdy b3RlOgo+IFdoZW4gdGhlIHN1bjRpIERSTSBkcml2ZXIgaXMgY29tcGlsZWQgd2l0aCBMUEFFIGVu YWJsZWQsIGRtYV9hZGRyX3QgdHVybnMKPiBpbnRvIGEgNjQtYml0IHR5cGUsIHdoaWNoIGNhdXNl cyB3YXJuaW5ncyB3aXRoIHNvbWUgZGVidWcgcHJpbnRrczoKPiA9PT09PT09PT09PT09PT09PQo+ IEluIGZpbGUgaW5jbHVkZWQgZnJvbQo+IGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9iYWNr ZW5kLmM6MTM6Ogo+IGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9iYWNrZW5kLmM6IEluIGZ1 bmN0aW9uICdzdW40aV9iYWNrZW5kX3VwZGF0ZV9sYXllcl9idWZmZXInOgo+IGRyaXZlcnMvZ3B1 L2RybS9zdW40aS9zdW40aV9iYWNrZW5kLmM6MTkzOjE5OiB3YXJuaW5nOgo+IGZvcm1hdCAnJXgn IGV4cGVjdHMgYXJndW1lbnQgb2YgdHlwZSAndW5zaWduZWQgaW50JywgYnV0IGFyZ3VtZW50IDMg aGFzCj4gdHlwZSAnZG1hX2FkZHJfdCB7YWthIGxvbmcgbG9uZyB1bnNpZ25lZCBpbnR9JyBbLVdm b3JtYXQ9XQo+ICAgRFJNX0RFQlVHX0RSSVZFUigiVXNpbmcgR0VNIEAgMHgleFxuIiwgZ2VtLT5w YWRkcik7Cj4gICAgICAgICAgICAgICAgICAgIF4KPiBpbmNsdWRlL2RybS9kcm1QLmg6MjA3OjM0 OiBub3RlOiBpbiBkZWZpbml0aW9uIG9mIG1hY3JvCj4gJ0RSTV9ERUJVR19EUklWRVInCj4gICAg IGRybV91dF9kZWJ1Z19wcmludGsoX19mdW5jX18sIGZtdCwgIyNhcmdzKTsgXAo+IC4uLi4uCj4g Cj4gVXNlIHRoZSBwcm9wZXIgcHJpbnRrIGZvcm1hdCBzcGVjaWZpZXIgWzFdIGZvciBkbWFfYWRk cl90IHdoaWNoIHRha2VzCj4gY2FyZSBvZiB0aG9zZSBkaWZmZXJlbmNlcy4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBBbmRyZSBQcnp5d2FyYSA8YW5kcmUucHJ6eXdhcmFAYXJtLmNvbT4KPiAKCkkgc3Vi bWl0dGVkIHRoZSBzYW1lIHBhdGNoIGEgbW9udGggYWdvLCBhbmQgaXQncyBhbHJlYWR5IGluIGxp bnV4LW5leHQsCkkgYXNzdW1lIGl0IHdpbGwgc2hvdyB1cCBpbiBtYWlubGluZSBzb29uLgoKCWFy bmQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181AbcFFWcX (ORCPT ); Mon, 6 Jun 2016 18:32:23 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:57598 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbcFFWcT (ORCPT ); Mon, 6 Jun 2016 18:32:19 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Andre Przywara , Maxime Ripard , David Airlie , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: sun4i: fix LPAE warnings Date: Mon, 06 Jun 2016 15:06:18 +0200 Message-ID: <4683820.tGQACgnbJT@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> References: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:AogCALeH2BmaRo/rEtZZY7/TSn2/7u9fkuhaTouKRhDwUrCjwpl h/9QV3n9SHSShWXxDKfXQ/2EG1uZ7ROGJFaGTHv+qprhkuXT670hsvr2L+d0+xweEVyt2YR eJtE/UhG9LtMXe7NFHOUx+eUJOIZVy6h5iGQXeBD8PstjE7QFq4MsDF78JbbNHdOvHSYSHX iitOQDIps21qjGsx1Yy4g== X-UI-Out-Filterresults: notjunk:1;V01:K0:pyNZfCs6zOQ=:QeahTwevFRX+L6ApdV+48o +vnAhyC92ZEEdzB2HmProNm3eDClfU2WsLrB2nJ39i4vxYVhEN/qRPOY4Ll4cU4QCVg8/RhKH DTCHttjwfPpQCVCzaycyYZeafYrizOlaePee8L2U26yF+mk1CqYHfeqYFC0nsc2TqkZxzjr4C TpN5tvwiq7+99AjzM1gY7bp68OvfIaSot34N5NmE8nz1TAK0W0iMMBh3jNJYusDz/0/UItDJp 3UYXGst8vI/KlNWNVu+DNAhIzGKfy+xJeCHzoBh3ZJ9RAxB4kzdwD7NJkw6WPF705bab3U9+U 1zGk4kcLce/91c+kLnb10tGK4BQA0x+SiTYCCXQ57n78hbPorgn7qIxWs+trYS3DWx4p694QC Lp9keBjXOjwb5EGSbEXZOIweaUHpj8vYnguWLZzNc7Sf/57uILazVpnN0VwjjYOcQOYJ/yleA 4f3g6t9NjMfjDTSJFMJDy6eS3E20IgdP1yqs5rhZBRM8JRgVNQ2O33lnzcmIT/Pq7FE7oJTwV egob+3bVmI03INAsvzggbTY93Qipf9cvUNoJoSvc1Wq4i+6jFi/vZ10ooGGD4W7X/Eyd2vAAE arSNl8pYtXlpolGaPklwE4B8W+cc410h1y/QIpLaNGQbu8rMYwkv1Uf5dQHVvpn7eyJ2E+QON pYr+gNEF25n1UAEw+6HCTx5CRrMNl5Adp9M6tNeeh2+Mnv/k5CcFSNlzcbJMlsDlwwM3fcFW3 hByliu84uz3kTQfN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, June 3, 2016 5:57:31 PM CEST Andre Przywara wrote: > When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns > into a 64-bit type, which causes warnings with some debug printks: > ================= > In file included from > drivers/gpu/drm/sun4i/sun4i_backend.c:13:: > drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer': > drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning: > format '%x' expects argument of type 'unsigned int', but argument 3 has > type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr); > ^ > include/drm/drmP.h:207:34: note: in definition of macro > 'DRM_DEBUG_DRIVER' > drm_ut_debug_printk(__func__, fmt, ##args); \ > ..... > > Use the proper printk format specifier [1] for dma_addr_t which takes > care of those differences. > > Signed-off-by: Andre Przywara > I submitted the same patch a month ago, and it's already in linux-next, I assume it will show up in mainline soon. arnd