From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
sshtylyov@ru.mvista.com, mlachwani@mvista.com
Subject: Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs
Date: Thu, 28 Jun 2007 10:54:14 -0400 [thread overview]
Message-ID: <4683CB96.9090609@garzik.org> (raw)
In-Reply-To: <20070628.230050.27955707.anemo@mba.ocn.ne.jp>
Seems to sane to me, by my quick read.
My only comment is: if invalid MAC address, generate a random one using
get_random_bytes() like some other net drivers do, rather than just failing.
Users should be able to use the NIC even if the MAC is invalid -- after
all, they can set one using ifconfig even if it is not available at
driver load time.
Jeff
next prev parent reply other threads:[~2007-06-28 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 14:22 [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs Atsushi Nemoto
2007-06-25 0:28 ` Ralf Baechle
2007-06-25 14:15 ` Atsushi Nemoto
2007-06-28 14:00 ` Atsushi Nemoto
2007-06-28 14:54 ` Jeff Garzik [this message]
2007-06-28 15:04 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4683CB96.9090609@garzik.org \
--to=jeff@garzik.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=mlachwani@mvista.com \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.