Patrick McHardy wrote: > PJ Waskiewicz wrote: > >> + >> static int __init prio_module_init(void) >> { >> - return register_qdisc(&prio_qdisc_ops); >> + int err; >> + err = register_qdisc(&prio_qdisc_ops); >> + if (!err) >> + err = register_qdisc(&rr_qdisc_ops); >> + return err; >> } >> > > > Thats still broken. I'll fix this and some minor cleanness issues myself so > you don't have to go through another resend. Here it is, fixed error handling and cleaned up prio_classify. There are still too many ifdefs in there for my taste, and I'm wondering whether the NET_SCH_MULTIQUEUE option should really be NETDEVICES_MULTIQUEUE. That would allow to move the #ifdefs to netif_subqueue_stopped and keep the qdiscs clean. I can send a patch for that on top of your patches.