All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrew Hall" <andrew.a.hall@gmail.com>
To: 'Mark Lord' <liml@rtr.ca>
Cc: linux-ide@vger.kernel.org, 'Tejun Heo' <htejun@gmail.com>,
	'Alan Cox' <alan@redhat.com>
Subject: RE: CF flash PATA on libata failure to attach
Date: Fri, 29 Jun 2007 12:15:58 +1000	[thread overview]
Message-ID: <46846b72.15588c0a.4c19.ffffeeb9@mx.google.com> (raw)
In-Reply-To: <46845BEE.90801@rtr.ca>

> Here's a slightly modified hack, which should leave your SATA
> drive working as well as the CF card.
> 
> Tejun / Alan : do we really want to continue attempting mdma2
> on a modern chipset such as ICH8 ???
> 
> The best mdma2 can do is the same throughput as pio4,
> and the bus occupancy is so high for mdma2 that it really
> probably isn't worthwhile -- only CF cards seem to use it
> in modern systems anyway.
> 
> Signed-off-by:  Mark Lord <mlord@pobox.com>
> ---
> --- linux/drivers/ata/ata_piix.c.orig	2007-06-10 18:58:27.000000000
> -0400
> +++ linux/drivers/ata/ata_piix.c	2007-06-28 21:09:04.000000000 -0400
> @@ -537,7 +537,7 @@
>  		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SCR |
>  				  PIIX_FLAG_AHCI,
>  		.pio_mask	= 0x1f,	/* pio0-4 */
> -		.mwdma_mask	= 0x07, /* mwdma0-2 */
> +		.mwdma_mask	= 0x00, /* mwdma0-2 */
>  		.udma_mask	= 0x7f,	/* udma0-6 */
>  		.port_ops	= &piix_sata_ops,
>  	},

That worked a treat! CF is flagged as PIO4 and HDD is now UDMA. I can't tell
you how grateful I am that you were able to point out the fix / modification
but I can certainly now sleep a bit easier.

Furthermore, if there is anything else I can do or would like me to test
while we have this type of hardware, please let me know.

Thanks again, Mark..


  parent reply	other threads:[~2007-06-29  2:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-18 10:02 CF flash IDE failure to attach with 2.6.20+ Andrew_hall
2007-06-18 11:26 ` Tejun Heo
2007-06-18 11:57   ` Alan Cox
2007-06-18 23:01     ` Andrew Hall
2007-06-19  5:00       ` Tejun Heo
2007-06-21  1:05         ` Andrew Hall
2007-06-21  3:02           ` Tejun Heo
2007-06-21  7:19             ` Andrew Hall
2007-06-21 14:45               ` Mark Lord
2007-06-21 15:09                 ` Andrew Hall
2007-06-26  8:51                 ` CF flash PATA on libata failure to attach Andrew Hall
2007-06-26 18:50                   ` Mark Lord
2007-06-27  3:57                     ` Andrew Hall
2007-06-27 14:08                       ` Mark Lord
2007-06-27 23:49                         ` Andrew Hall
2007-06-28 17:37                           ` Mark Lord
2007-06-29  0:35                             ` Andrew Hall
2007-06-29  1:10                               ` Mark Lord
2007-06-29  1:36                                 ` Tejun Heo
2007-06-29  2:26                                   ` Mark Lord
2007-06-29  2:15                                 ` Andrew Hall [this message]
2007-06-29  2:28                                   ` Mark Lord
2007-06-29  3:24                                     ` Andrew Hall
2007-06-29  7:34                                     ` Andrew Hall
2007-06-29 10:17                                       ` Alan Cox
2007-07-02 10:58                                         ` Tejun Heo
2007-07-03  6:13                                         ` Albert Lee
2007-06-29 10:06                                 ` Alan Cox
2007-06-25  9:05             ` CF flash IDE failure to attach with 2.6.20+ Andrew Hall
2007-06-18 23:23   ` Andrew Hall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46846b72.15588c0a.4c19.ffffeeb9@mx.google.com \
    --to=andrew.a.hall@gmail.com \
    --cc=alan@redhat.com \
    --cc=htejun@gmail.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.