From: "H. Peter Anvin" <hpa@zytor.com>
To: "H. J. Lu" <hjl@lucon.org>
Cc: joerg.roedel@amd.com, linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: Fix SVM MSR indexes for 32bit kernel
Date: Fri, 29 Jun 2007 14:27:57 -0400 [thread overview]
Message-ID: <46854F2D.9080604@zytor.com> (raw)
In-Reply-To: <20070629153815.GA18297@lucon.org>
H. J. Lu wrote:
> }
> [hjl@gnu-5 tmp]$ gcc -m32 -S foo.c
> foo.c: In function â_disabledâfoo.c:7: error: impossible register
> constraint in âmâoo.c:12: confused by earlier errors, bailing out
> [hjl@gnu-5 tmp]$
>
> on 32bit. This patch removes the ULL suffix in SVM MSR indexes.
>
>
> H.J.
> --- linux-2.6.21.i686/drivers/kvm/svm.h.msr 2007-06-28 22:42:12.000000000 -0700
> +++ linux-2.6.21.i686/drivers/kvm/svm.h 2007-06-29 08:03:09.000000000 -0700
> @@ -175,8 +175,8 @@ struct __attribute__ ((__packed__)) vmcb
> #define SVM_CPUID_FUNC 0x8000000a
>
> #define MSR_EFER_SVME_MASK (1ULL << 12)
> -#define MSR_VM_CR 0xc0010114ULL
> -#define MSR_VM_HSAVE_PA 0xc0010117ULL
> +#define MSR_VM_CR 0xc0010114
> +#define MSR_VM_HSAVE_PA 0xc0010117
>
Please take the MSR indicies out of this file and move them to
include/asm-i386/msr-index.h.
-hpa
prev parent reply other threads:[~2007-06-29 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 15:38 PATCH: Fix SVM MSR indexes for 32bit kernel H. J. Lu
2007-06-29 18:27 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46854F2D.9080604@zytor.com \
--to=hpa@zytor.com \
--cc=hjl@lucon.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.