From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: netdev@vger.kernel.org
Subject: sunhme: some cleanups
Date: Thu, 03 Feb 2022 17:20:32 +0100 [thread overview]
Message-ID: <4686583.GXAFRqVoOG@eto.sf-tec.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
Hi,
it still matches my sense of humor to see fries offered in a network driver,
so every now and then I point someone to the driver. This time I looked a bit
more around and noticed some things I have already done wrong before myself.
Time to clean them up so it's still funny while serving as a good example ;)
Things that are changed:
-drop unused tx_dump_ring()
-fix version number inconsistency
-forward error code from pci_enable_device()
Things that I may also do in the, but can't test because I don't have any
hardware:
-switch to devres, which fixes a memleak of the dma_alloc_coherent() memory if
register_netdev() fails [mostly done]
-use netdev_* print macros to print the device name in a consistent way
I can also send an immediate fix for the first one if you prefer.
Greetings,
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next reply other threads:[~2022-02-03 16:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 16:20 Rolf Eike Beer [this message]
2022-02-03 16:21 ` [PATCH 1/3] sunhme: remove unused tx_dump_ring() Rolf Eike Beer
2022-07-27 3:42 ` Sean Anderson
2022-02-03 16:22 ` [PATCH 2/3] sunhme: fix the version number in struct ethtool_drvinfo Rolf Eike Beer
2022-02-03 17:12 ` Andrew Lunn
2022-02-05 11:27 ` Rolf Eike Beer
2022-02-05 14:48 ` Andrew Lunn
2022-02-05 15:57 ` Rolf Eike Beer
2022-02-05 16:32 ` Andrew Lunn
2022-02-03 21:53 ` Jakub Kicinski
2022-02-14 18:33 ` [PATCH 2/3 v2] " Rolf Eike Beer
2022-02-03 16:23 ` [PATCH 3/3] sunhme: forward the error code from pci_enable_device() Rolf Eike Beer
2022-07-27 3:48 ` Sean Anderson
2022-02-14 18:31 ` [PATCH 4/x] sunhme: switch to devres Rolf Eike Beer
2022-07-27 3:49 ` Sean Anderson
2022-07-27 3:58 ` Sean Anderson
2022-07-28 19:52 ` Rolf Eike Beer
2022-07-29 0:33 ` Sean Anderson
2022-08-01 15:14 ` Rolf Eike Beer
2022-08-24 15:45 ` Rolf Eike Beer
2022-08-24 15:57 ` Sean Anderson
2022-08-29 13:22 ` [PATCH 4/4 v2] " Rolf Eike Beer
2022-08-30 0:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4686583.GXAFRqVoOG@eto.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.