Re: [PATCH v3 1/9] mhi: Add mhi_controller_initialize helper

[Bhaumik Bhatt <bbhatt@codeaurora.org>]

On 2020-11-27 09:42 PM, Manivannan Sadhasivam wrote:
> On Thu, Nov 26, 2020 at 04:28:59PM +0100, Loic Poulain wrote:
>> This function allows to initialize a mhi_controller structure.
>> Today, it only zeroing the structure.
>> 
> 
> That's what kzalloc is also doing, right?
> 
> Thanks,
> Mani
> 
>> Use this function from mhi_alloc_controller so that any further
>> initialization can be factorized in initalize function.
>> 
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>> ---
>>  drivers/bus/mhi/core/init.c | 7 +++++++
>>  include/linux/mhi.h         | 6 ++++++
>>  2 files changed, 13 insertions(+)
>> 
>> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
>> index 96cde9c..4acad28 100644
>> --- a/drivers/bus/mhi/core/init.c
>> +++ b/drivers/bus/mhi/core/init.c
>> @@ -1021,11 +1021,18 @@ void mhi_unregister_controller(struct 
>> mhi_controller *mhi_cntrl)
>>  }
>>  EXPORT_SYMBOL_GPL(mhi_unregister_controller);
>> 
>> +void mhi_initialize_controller(struct mhi_controller *mhi_cntrl)
>> +{
>> +	memset(mhi_cntrl, 0, sizeof(*mhi_cntrl));
>> +}
>> +EXPORT_SYMBOL_GPL(mhi_initialize_controller);
>> +
>>  struct mhi_controller *mhi_alloc_controller(void)
>>  {
>>  	struct mhi_controller *mhi_cntrl;
>> 
>>  	mhi_cntrl = kzalloc(sizeof(*mhi_cntrl), GFP_KERNEL);
>> +	mhi_initialize_controller(mhi_cntrl);
This line is not required here.
>> 
>>  	return mhi_cntrl;
>>  }
>> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
>> index 5721a0a..30c676d 100644
>> --- a/include/linux/mhi.h
>> +++ b/include/linux/mhi.h
>> @@ -537,6 +537,12 @@ struct mhi_driver {
>>  #define to_mhi_device(dev) container_of(dev, struct mhi_device, dev)
>> 
>>  /**
>> + * mhi_initialize_controller - Initialize MHI Controller structure
>> + * @mhi_cntrl: MHI controller structure to initialize
>> + */
>> +void mhi_initialize_controller(struct mhi_controller *mhi_cntrl);
>> +
>> +/**
>>   * mhi_alloc_controller - Allocate the MHI Controller structure
>>   * Allocate the mhi_controller structure using zero initialized 
>> memory
>>   */
>> --
>> 2.7.4
>> 

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project