From: Jeff Garzik <jeff@garzik.org>
To: Veena Parat <Veena.Parat@neterion.com>
Cc: netdev@vger.kernel.org, Leonid.Grossman@neterion.com,
ramkrishna.vepa@neterion.com, santosh.rastapur@neterion.com,
Sivakumar.Subramani@neterion.com, sreenivasa.honnur@neterion.com,
alicia.pena@neterion.com, sriram.rapuru@neterion.com
Subject: Re: [PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver
Date: Mon, 02 Jul 2007 08:18:00 -0400 [thread overview]
Message-ID: <4688ECF8.9000204@garzik.org> (raw)
In-Reply-To: <Pine.GSO.4.10.10706190557030.2608-100000@guinness>
Veena Parat wrote:
> 1.Removed MSI support from driver - unused feature
> 2.Removed pci_request_regions call to allocate bar2 as it is not used in driver
> 3.Removed pci_release_regions since pci_request_regions is not done
This is wrong. pci_request_regions() grabs all the regions for the
associated PCI device, which is the desired behavior.
Using request_mem_region() is not what you want to do for PCI devices.
next prev parent reply other threads:[~2007-07-02 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 9:59 [PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver Veena Parat
2007-07-02 12:18 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-12 10:18 Veena Parat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4688ECF8.9000204@garzik.org \
--to=jeff@garzik.org \
--cc=Leonid.Grossman@neterion.com \
--cc=Sivakumar.Subramani@neterion.com \
--cc=Veena.Parat@neterion.com \
--cc=alicia.pena@neterion.com \
--cc=netdev@vger.kernel.org \
--cc=ramkrishna.vepa@neterion.com \
--cc=santosh.rastapur@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
--cc=sriram.rapuru@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.