From: Jeff Garzik <jgarzik@pobox.com>
To: Olof Johansson <olof@lixom.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/9] pasemi_mac: Clean TX ring in poll
Date: Mon, 02 Jul 2007 08:34:22 -0400 [thread overview]
Message-ID: <4688F0CE.9020600@pobox.com> (raw)
In-Reply-To: <20070622200501.GC11723@lixom.net>
Olof Johansson wrote:
> Clean the TX ring in the poll call, to avoid sitting on mapped buffers
> for a long time. NFS doesn't seem to like it much, for example.
>
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> Index: netdev-2.6/drivers/net/pasemi_mac.c
> ===================================================================
> --- netdev-2.6.orig/drivers/net/pasemi_mac.c
> +++ netdev-2.6/drivers/net/pasemi_mac.c
> @@ -1052,6 +1052,7 @@ static int pasemi_mac_poll(struct net_de
> int pkts, limit = min(*budget, dev->quota);
> struct pasemi_mac *mac = netdev_priv(dev);
>
> + pasemi_mac_clean_tx(mac);
> pkts = pasemi_mac_clean_rx(mac, limit);
Why is this needed? Is your TX interrupt mitigated or delayed somehow?
In general, drivers should only clean TX in one place. Doing so in
multiple places tends to indicate a bug somewhere.
You are correct that you should not sit on buffers for too long -- that
increases latency of all who are waiting on those buffers to be sent.
next prev parent reply other threads:[~2007-07-02 12:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070622194720.614405000@lixom.net>
2007-06-22 20:04 ` [PATCH 1/9] pasemi_mac: Fix TX interrupt threshold Olof Johansson
2007-07-02 12:37 ` Jeff Garzik
2007-06-22 20:05 ` [PATCH 2/9] pasemi_mac: Clean TX ring in poll Olof Johansson
2007-07-02 12:34 ` Jeff Garzik [this message]
2007-07-03 20:31 ` Olof Johansson
2007-06-22 20:05 ` [PATCH 3/9] pasemi_mac: Abstract out register access Olof Johansson
2007-07-02 12:32 ` Jeff Garzik
2007-06-22 20:05 ` [PATCH 4/9] pasemi_mac: Use MMIO instead of pci config accessors Olof Johansson
2007-07-02 12:37 ` Jeff Garzik
2007-06-22 20:05 ` [PATCH 5/9] pasemi_mac: Enable L2 caching of packet headers Olof Johansson
2007-06-22 20:05 ` [PATCH 6/9] pasemi_mac: Simplify memcpy for short receives Olof Johansson
2007-06-22 20:05 ` [PATCH 7/9] pasemi_mac: Minor performance tweaks Olof Johansson
2007-06-22 20:05 ` [PATCH 8/9] pasemi_mac: Reduce locking when cleaning TX ring Olof Johansson
2007-06-22 20:05 ` [PATCH 9/9] pasemi_mac: Enable LLTX Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4688F0CE.9020600@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.