Re: [PATCH 0/2] libnetfitler_queue improvements

[Patrick McHardy <kaber@trash.net>]

Yasuyuki KOZAKAI wrote:
> Hi Patrick,
> 
> These are for 2.6.23 tree. The first patch might be better to
> go 2.6.22. Either one is fine with me.


The queue handler unregistration stuff is really strange, so I'd rather
have it get some testing. I've applied both patches to 2.6.23, thanks.

> BTW, I think we'd better to do nothing for NFQNL_CFG_CMD_PF_[UN]BIND
> commands and to register queue handlers at init() automatically after
> removing ip[6]_queue.
> 
> Because they are diffcult to use. Even if we apply the first patch, a user
> process can unregister a queue handler registered by other process. And
> there is no way to count the number of process to use the handler (refcount
> per handler doesn't help because process can issue [un]binding command over
> again and again).


Its a horrible hack. Best thing would had been to make ip_queue and
nfnetlink_queue mutually exclusive from the beginning and provide
an actually working compat library.

I guess what we could do now is to refcount the bindings and store
the bind state in the queue instance and allow each process to
unbind only the family it bound to. When processes close their
netlink socket their own bindings should also be released.