All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Mark Lord <mlord@pobox.com>,
	greg.freemyer@gmail.com
Subject: Re: [PATCH] sata_inic162x: disable LBA48 devices
Date: Mon, 02 Jul 2007 10:14:35 -0400	[thread overview]
Message-ID: <4689084B.1050004@garzik.org> (raw)
In-Reply-To: <46846F64.7000201@gmail.com>

Tejun Heo wrote:
> sata_inic162x can't do LBA48 properly yet and is likely to corrupt
> data on drives larger than LBA28 limit.  Disable LBA48 devices during
> device configuration.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
>  drivers/ata/sata_inic162x.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: work/drivers/ata/sata_inic162x.c
> ===================================================================
> --- work.orig/drivers/ata/sata_inic162x.c
> +++ work/drivers/ata/sata_inic162x.c
> @@ -496,6 +496,13 @@ static void inic_dev_config(struct ata_d
>  	/* inic can only handle upto LBA28 max sectors */
>  	if (dev->max_sectors > ATA_MAX_SECTORS)
>  		dev->max_sectors = ATA_MAX_SECTORS;
> +
> +	if (dev->n_sectors >= 1 << 28) {
> +		ata_dev_printk(dev, KERN_ERR,
> +	"ERROR: This driver doesn't support LBA48 yet and may cause\n"
> +	"                data corruption on such devices.  Disabling.\n");
> +		ata_dev_disable(dev);
> +	}

applied



      reply	other threads:[~2007-07-02 14:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-29  2:33 [PATCH] sata_inic162x: disable LBA48 devices Tejun Heo
2007-07-02 14:14 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4689084B.1050004@garzik.org \
    --to=jeff@garzik.org \
    --cc=greg.freemyer@gmail.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mlord@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.