From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
stable@kernel.org, Chuck Ebbert <76306.1226@compuserve.com>
Subject: Re: [PATCH] i386 - Fix regression, endless loop in ptrace singlestep over an int80
Date: Mon, 02 Jul 2007 14:07:04 -0700 [thread overview]
Message-ID: <468968F8.9060700@goop.org> (raw)
In-Reply-To: <468965D8.7020405@windriver.com>
Jason Wessel wrote:
>
> Attached is a patch with a complete test case to fix the regression
> introduced by the commit: 635cf99a80f4ebee59d70eb64bb85ce829e4591f.
>
> This patch is against kernel 2.6.21 but the fix is applicable to
> 2.6.21 and up. Prior to the commit that introduced the regression the
> ltp ptrace tests would complete correctly. I augmented the test case
> from the original patch header to include the problem case that shows
> up in the lpt tests.
>
> The brief summary is that the the TIF_SINGLESTEP state needs to be
> altered on the exit path and not the entry path to a syscall, else it
> can loop forever on the same instruction right after the syscall is
> executed in certain cases.
Looks reasonable to me, but what under what circumstances can
TIF_SINGLESTEP get lost?
J
next prev parent reply other threads:[~2007-07-02 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 20:53 [PATCH] i386 - Fix regression, endless loop in ptrace singlestep over an int80 Jason Wessel
2007-07-02 21:07 ` Jeremy Fitzhardinge [this message]
2007-07-02 22:03 ` Chuck Ebbert
2007-07-02 22:20 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468968F8.9060700@goop.org \
--to=jeremy@goop.org \
--cc=76306.1226@compuserve.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.