Re: [PATCH RFC] mac80211: Make stop_queues() usable

[Patrick McHardy <kaber@trash.net>]

Michael Buesch wrote:
> On Tuesday 03 July 2007 06:09:19 Michael Wu wrote:
> 
>>On Monday 02 July 2007 13:35, Michael Buesch wrote:
>>
>>>+	netif_tx_lock_bh(mdev);
>>> 	for (i = 0; i < hw->queues; i++)
>>> 		ieee80211_stop_queue(hw, i);
>>>+	netif_tx_unlock_bh(mdev);
>>
>>Well, looks like this will break stopping all tx queues from the tx handler by 
>>deadlocking. It may be useless for bcm43xx to call ieee80211_stop_queue, but 
>>there are other drivers which rely on it.


The wireless multiqueue handling should be replaced by the generic
implementation in net-2.6.23 (using prio, seperating out the wme
classifier and killing the broken scheduler). You don't need to
stop individual subqueues for a full shutdown with that implementation,
you can just stop the global queue. Not sure if that really helps for
this case though since I didn't look to deep into this code.