From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 9/15] ide: add PIO masks
Date: Tue, 03 Jul 2007 23:28:17 +0400 [thread overview]
Message-ID: <468AA351.4090509@ru.mvista.com> (raw)
In-Reply-To: <200706302107.42458.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * Add ATA_PIO[0-6] defines to <linux/ata.h>.
> * Add ->pio_mask field to ide_pci_device_t and ide_hwif_t.
> * Add PIO masks to host drivers.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Not sure if my ACK applies now...
> Index: b/drivers/ide/pci/jmicron.c
> ===================================================================
> --- a/drivers/ide/pci/jmicron.c
> +++ b/drivers/ide/pci/jmicron.c
> @@ -180,6 +180,7 @@ fallback:
> .autodma = AUTODMA, \
> .bootable = ON_BOARD, \
> .enablebits = { {0x40, 1, 1}, {0x40, 0x10, 0x10} }, \
> + .pio_mask = ATA_PIO5, \
> }
Just noticed that this driver does nothing in its tuneproc() method. So,
this mask is unrealistic. The method needs to be dropped for now along with
config-jmicron_chipset_for_pio() -- ptobably, with FIXME added.
MBR, Sergei
next prev parent reply other threads:[~2007-07-03 19:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 19:07 [PATCH 9/15] ide: add PIO masks Bartlomiej Zolnierkiewicz
2007-06-30 20:04 ` Jeff Garzik
2007-07-03 17:40 ` Sergei Shtylyov
2007-07-03 19:12 ` Bartlomiej Zolnierkiewicz
2007-07-06 0:40 ` Jeff Garzik
2007-07-03 19:28 ` Sergei Shtylyov [this message]
2007-07-03 20:08 ` Bartlomiej Zolnierkiewicz
2007-07-03 20:35 ` Sergei Shtylyov
2007-07-03 22:00 ` Alan Cox
2007-07-04 14:24 ` Sergei Shtylyov
2007-07-04 14:31 ` Alan Cox
2007-07-04 19:02 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468AA351.4090509@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.