From: Morten Helgesen <morten@sourcepoet.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths
Date: Tue, 03 Jul 2007 23:33:38 +0200 [thread overview]
Message-ID: <468AC0B2.9000404@sourcepoet.org> (raw)
In-Reply-To: <20070703162655.6a001fdc@the-village.bc.nu>
Alan Cox wrote:
> On Tue, 03 Jul 2007 16:39:05 +0200
> Morten Helgesen <morten@sourcepoet.org> wrote:
>
>
>> Alan Cox wrote:
>>
>> [...snip...]
>>
>>> @@ -75,11 +64,11 @@
>>> if (! (port->flags & ASYNC_INITIALIZED)) return;
>>>
>>> /* Take a lock on the serial tranmit buffer! */
>>> - LOCKIT;
>>> + mutex_lock(& port->port_write_mutex);
>>>
>>>
>> ^ Contains additional whitespace.
>>
>
>
> Its an old driver, it doesn't follow the coding style too well at all -
> viz stuff like if (! ( the line above. Given its age and limited userbase
> I don't plan to go and make it conform either, but I will take patches
> for the formatting (and the spelling errors it is full of) from someone
> who wants to do the work.
>
> Alan
Ok, so how is this for a start?
- Proper indenting.
- Fixes for the most obvious typos and spelling errors.
Signed-off-by: Morten Helgesen <morten@sourcepoet.org>
== Morten
next prev parent reply other threads:[~2007-07-03 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 14:20 [PATCH] genericserial: Remove bogus optimisation check and dead code paths Alan Cox
2007-07-03 14:39 ` Morten Helgesen
2007-07-03 15:26 ` Alan Cox
2007-07-03 21:33 ` Morten Helgesen [this message]
2007-07-03 21:36 ` Morten Helgesen
2007-07-03 22:31 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468AC0B2.9000404@sourcepoet.org \
--to=morten@sourcepoet.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.