From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [Patch] ARCH_HAS_DEV_MEM patch for Xwindow on IA64machine Date: Wed, 04 Jul 2007 13:04:50 +0100 Message-ID: <468BA902.76E4.0078.0@novell.com> References: <20070704203821.B340.KAMA@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20070704203821.B340.KAMA@jp.fujitsu.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: kama@jp.fujitsu.com Cc: xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Jun Kamada 04.07.07 13:43 >>> >We would like to support Xwindow on IA64 by remapping machine address to >pseudo physical address at PCI device initialization (pci_acpi_scan_root()= >in arch/ia64/pci/pci.c) but at "mmap /dev/mem" systemcall. >With the new scheme, we need no longer the archtecture specific memory >operations described above. You only talk about X - isn't it possible that there are other users of = this interface? Also, >--- a/drivers/xen/Kconfig Thu Jun 21 15:12:20 2007 +0900 >+++ b/drivers/xen/Kconfig Thu Jun 21 15:13:21 2007 +0900 >@@ -273,4 +273,8 @@ config XEN_SMPBOOT > default y > depends on SMP >=20 >+config XEN_DEVMEM >+ bool >+ default y >+ > endif This seems pretty useless unless ia64 doesn't use drivers/xen/Kconfig = (which would be a mistake I think). >--- a/drivers/xen/Makefile Thu Jun 21 15:12:20 2007 +0900 >+++ b/drivers/xen/Makefile Thu Jun 21 15:13:21 2007 +0900 >@@ -5,9 +5,9 @@ obj-y +=3D xenbus/ > obj-y +=3D xenbus/ > obj-y +=3D gntdev/ > obj-y +=3D balloon/ >-obj-y +=3D char/ >=20 > obj-y +=3D util.o >+obj-$(CONFIG_XEN_DEVMEM) +=3D char/ > obj-$(CONFIG_XEN_BLKDEV_BACKEND) +=3D blkback/ > obj-$(CONFIG_XEN_BLKDEV_TAP) +=3D blktap/ > obj-$(CONFIG_XEN_NETDEV_BACKEND) +=3D netback/ This is certainly wrong. Even if driver/xen/char/ currently only has a single file, you should descend into that directory. The conditional (if needed at all) should then be in driver/xen/char/Makefile. Jan