All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: xen-devel@lists.xensource.com
Subject: bus_to_virt()
Date: Thu, 05 Jul 2007 11:04:07 +0100	[thread overview]
Message-ID: <468CDE37.76E4.0078.0@novell.com> (raw)

Isn't it inappropriate for bus_to_virt() to use, through machine_to_phys(),
mfn_to_pfn() rather than mfn_to_local_pfn()? If a foreign domain's address
gets uses here, the virtual address returned might be anything. I'm
specifically asking because I finally want to make an attempt to (a) merge
our swiotlb.c up with native's lib/swiotlb.c and then (b) move ours to
lib/swiotlb-xen.c. Native, however, uses a virtual address range check, and
hence the bus_to_virt() return value must reliable. If changing the macro
globally isn't appropriate (I can't see what valid uses there might be for this
macro with non-local addresses, hence a change like this would be benign to
all other users), I'd have to hand-craft a mechanism local to swiotlb.c to that
I can keep the delta to native down.

Thanks, Jan

             reply	other threads:[~2007-07-05 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-05 10:04 Jan Beulich [this message]
2007-07-05 10:13 ` bus_to_virt() Keir Fraser
2007-07-05 10:27   ` bus_to_virt() Jan Beulich
2007-07-05 10:39   ` bus_to_virt() Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468CDE37.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.