All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Chapman <jchapman@katalix.com>
To: "Rémi Denis-Courmont" <rdenis@simphalempin.com>
Cc: netdev@vger.kernel.org, remi.denis-courmont@nokia.com
Subject: Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code
Date: Thu, 05 Jul 2007 18:25:50 +0100	[thread overview]
Message-ID: <468D299E.5070902@katalix.com> (raw)
In-Reply-To: <200707051951.03619@auguste.remlab.net>

Rémi Denis-Courmont wrote:

> By the way, couldn't encap_type be remove altogether (using two slightly 
> different callbacks for ESP) from udp_sock?

The notion of encap_type is needed for the setsockopt call so it would 
have to stay in the API. If it were removed from udp_sock, getsockopt 
would have to derive the encap_type from encap_rcv funcptr values, which 
would be messy. I think it might complicate the logic in ESP too.

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development


  reply	other threads:[~2007-07-05 17:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-05 16:18 [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code James Chapman
2007-07-05 16:45 ` Patrick McHardy
2007-07-05 16:50   ` Rémi Denis-Courmont
2007-07-05 17:25     ` James Chapman [this message]
2007-07-06  7:55       ` Rémi Denis-Courmont
2007-07-06 13:31         ` Patrick McHardy
2007-07-11  6:06           ` David Miller
2007-07-06  0:08   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468D299E.5070902@katalix.com \
    --to=jchapman@katalix.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdenis@simphalempin.com \
    --cc=remi.denis-courmont@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.