All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dougg@torque.net>
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: James.Bottomley@SteelEye.com, akpm@linux-foundation.org,
	jeff@garzik.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 0/3] clean gendisk out of scsi ULD structs
Date: Thu, 05 Jul 2007 18:09:27 -0400	[thread overview]
Message-ID: <468D6C17.8030006@torque.net> (raw)
In-Reply-To: <20070705140636.6dbabd6f.kristen.c.accardi@intel.com>

Kristen Carlson Accardi wrote:
> Since gendisk will now become part of struct scsi_device, we don't need
> to store this value in any private data structs where they already store
> scsi_device.  This series cleans up a few drivers which did this.

Since a scsi_device object is usually a SCSI logical unit,
one wonders why it would contain a gendisk object. Logical
units aren't necessarily disks, they might be enclosures or
just place holders that respond to an INQUIRY (e.g. lun=0
when the enclosing target has other active lus whose lun!=0).

Doug Gilbert

  reply	other threads:[~2007-07-05 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-05 21:06 [patch 0/3] clean gendisk out of scsi ULD structs Kristen Carlson Accardi
2007-07-05 22:09 ` Douglas Gilbert [this message]
2007-07-05 23:03   ` Al Viro
2007-07-05 23:02 ` Al Viro
2007-07-05 23:14   ` James Bottomley
2007-07-06 20:02 ` James Bottomley
2007-07-07  3:25   ` Douglas Gilbert
2007-07-07 15:15     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468D6C17.8030006@torque.net \
    --to=dougg@torque.net \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.