From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 6/17] Reorganize and fix problems (returns) in the bootm command.
Date: Thu, 05 Jul 2007 19:46:46 -0400 [thread overview]
Message-ID: <468D82E6.3020000@gmail.com> (raw)
In-Reply-To: <20070705193817.580D7353A64@atlas.denx.de>
Wolfgang Denk wrote:
> In message <468D0E3D.3000308@freescale.com> you wrote:
>> Jerry Van Baren wrote:
>> > We've smashed our underpinnings by uncompressing linux over our
>> > interrupt vectors before the checksum catches the problem. There is no
>> > way back other than a reset.
>>
>> Can you include this explanation as a comment in the code at the exact point this occurs?
>
> Ummm... what exactly is not clear enough with this comment in
> "common/cmd_bootm.c":
>
> /*
> * We have reached the point of no return: we are going to
> * overwrite all exception vector code, so we cannot easily
> * recover from any failures any more...
> */
>
> ??? Do you need additional explanations? What should be added?
>
> Best regards,
>
> Wolfgang Denk
Maybe if we enhanced the comment so it catches the eye of your average
geek. Perhaps one of these:
<http://www.chris.com/ASCII/art/html/nakedladies.html>
Of course, we would have to do #ifdef MALE around it...
;-)
gvb (who missed the comment himself, the first time around)
next prev parent reply other threads:[~2007-07-05 23:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 1:15 [U-Boot-Users] [PATCH 6/17] Reorganize and fix problems (returns) in the bootm command Jerry Van Baren
2007-07-05 2:43 ` Grant Likely
2007-07-05 10:54 ` Jerry Van Baren
2007-07-05 14:13 ` Grant Likely
2007-07-05 14:30 ` Jerry Van Baren
2007-07-05 19:36 ` Wolfgang Denk
2007-07-05 15:29 ` Timur Tabi
2007-07-05 15:33 ` Jerry Van Baren
2007-07-05 19:38 ` Wolfgang Denk
2007-07-05 23:46 ` Jerry Van Baren [this message]
2007-07-06 2:25 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468D82E6.3020000@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.