From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org, bruinjm@xs4all.nl
Subject: Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY
Date: Thu, 05 Jul 2007 19:53:38 -0400 [thread overview]
Message-ID: <468D8482.9040203@garzik.org> (raw)
In-Reply-To: <20070705133926.66050cce@the-village.bc.nu>
Alan Cox wrote:
>> but IDE simply ignores the error and continues to operate in MWDMA
>> mode, so I guess we can remove the 'temporary fix' comment or add
>> another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it.
>
> Should we warn in these cases ? Or issue a new identify and check the
> mode activated ?
The latter, issuing a new identify, is really what you want to do.
AFAICT that's the canonical method of querying the device's knowledge of
its mode settings.
Jeff
next prev parent reply other threads:[~2007-07-05 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 3:31 [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY Tejun Heo
2007-07-05 12:39 ` Alan Cox
2007-07-05 23:53 ` Jeff Garzik [this message]
2007-07-06 6:42 ` Tejun Heo
2007-07-11 1:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468D8482.9040203@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bruinjm@xs4all.nl \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.