All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Garzik <jeff@garzik.org>,
	linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2.6.22-rc7] libata: fix assigned IRQ reporting
Date: Fri, 06 Jul 2007 15:40:45 +0900	[thread overview]
Message-ID: <468DE3ED.3040100@gmail.com> (raw)
In-Reply-To: <20070705224536.GA9148@electric-eye.fr.zoreil.com>

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Francois Romieu wrote:
> Tejun Heo <htejun@gmail.com> :
> [...]
>> Apparently, I'm more confused than you are.  My "master" was at 872aad45
>> but my index was at rc7.  Can you please force checkout the head and
>> re-test?  I've tested both native and legacy modes and it's fixed here.
> 
> I have done a forced checkout + mrproper before rebuild and there is no
> difference.
> 
> Complete dmesg is attached.

Hmmmm... Weird.  Can you please apply the attached patch and post boot
dmesg?  Thanks.

-- 
tejun

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 786 bytes --]

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index fa1c22c..1a5bd75 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1069,6 +1069,7 @@ int ata_pci_init_one(struct pci_dev *pdev,
 		rc = devm_request_irq(dev, pdev->irq, pi->port_ops->irq_handler,
 				      IRQF_SHARED, DRV_NAME, host);
 		host->irq = pdev->irq;
+		printk("XXX native mode irq=%lu\n", host->irq);
 	} else {
 		irq_handler_t handler[2] = { host->ops->irq_handler,
 					     host->ops->irq_handler };
@@ -1076,6 +1077,7 @@ int ata_pci_init_one(struct pci_dev *pdev,
 		void *dev_id[2] = { host, host };
 
 		rc = ata_request_legacy_irqs(host, handler, irq_flags, dev_id);
+		printk("XXX legacy mode irq=%lu irq2=%lu\n", host->irq, host->irq2);
 	}
 	if (rc)
 		goto err_out;

  reply	other threads:[~2007-07-06  6:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-02 16:38 [PATCH 2.6.22-rc7] libata: fix assigned IRQ reporting Tejun Heo
2007-07-02 21:47 ` Francois Romieu
2007-07-03  1:19   ` Tejun Heo
2007-07-03 22:22     ` Francois Romieu
2007-07-04  5:33       ` Tejun Heo
2007-07-04  5:46         ` Tejun Heo
2007-07-04 18:59           ` Francois Romieu
2007-07-05  2:38             ` Tejun Heo
2007-07-05 22:45               ` Francois Romieu
2007-07-06  6:40                 ` Tejun Heo [this message]
2007-07-10 18:24                   ` Francois Romieu
2007-07-10 21:44                     ` Francois Romieu
2007-07-03 14:07 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468DE3ED.3040100@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.