All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: NFS List <nfs@lists.sourceforge.net>
Subject: maintainership question about nfs-utils/util/mount
Date: Fri, 06 Jul 2007 16:13:23 -0400	[thread overview]
Message-ID: <468EA263.5010909@oracle.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

I'm looking at nfs-utils/utils/mount in order to patch in support for 
passing a string of mount options to the kernel instead of an 
nfs_mount_data.

In mount.c, main() invokes nfsmount() in nfsmount.c.  nfsmount() defines 
a structure on the stack called "data", then returns a pointer to "data" 
which is then passed to the kernel by main().

I think the only way this continues to work is that there are three 1024 
character buffers defined in nfsmount()'s stack frame before "data," 
which places "data" far enough up the stack that subsequent function 
calls in main() don't smash it.

Although this doesn't cause bad behavior today, it needs to be fixed to 
prevent future changes from breaking things badly.

Also found an interesting error message in here:

   permission died - no match for fstab

Should probably be "permission denied".  I'm not really sure what "no 
match for fstab" means, but looking at the context, this message appears 
if a non-root user tries to mount something that isn't already listed in 
/etc/fstab.

What's the current blessed procedure for sending patches and fixes for 
this particular code?  Mail to agud@redhat.com (last touch rule, and 
author of mount.c) is rejected.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 315 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
email;internet:chuck dot lever at nospam oracle dot com
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

             reply	other threads:[~2007-07-06 20:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-06 20:13 Chuck Lever [this message]
2007-07-16 15:42 ` maintainership question about nfs-utils/util/mount Jeff Layton
2007-07-16 16:25   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468EA263.5010909@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.