From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3EC7C433FE for ; Sat, 15 Jan 2022 03:38:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbiAODi5 (ORCPT ); Fri, 14 Jan 2022 22:38:57 -0500 Received: from out2.migadu.com ([188.165.223.204]:58447 "EHLO out2.migadu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230494AbiAODi5 (ORCPT ); Fri, 14 Jan 2022 22:38:57 -0500 Message-ID: <468c411e-8f68-00da-5c44-a3de72bf0d9b@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1642217935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oksPbU2p4JNE2Xg8ORjZEeE4yS9CBi97jfLKKNmQG5w=; b=DMVHyJbENu5jdeKXinMzgXkGSeR4j3Ps16yOrk7BlJdPHgbGAfAbf2evSQD6OS5eD6040p Bn1m3yqutAToct3r8T+5ahxINqkrnmLSeqD2O0EkZZeDRp7PpyYrpI2SVHMb/zsQysuuVM YmQOakBnCnJ1Gdfr3EwqWznruLylvsc= Date: Sat, 15 Jan 2022 11:38:44 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] RDMA/rxe: Check the last packet by RXE_END_MASK To: "yangx.jy@fujitsu.com" Cc: Haakon Bugge , Jason Gunthorpe , "david.marchand@6wind.com" , OFED mailing list , "rpearsonhpe@gmail.com" , "yanjun.zhu@linux.dev" References: <20211229034438.1854908-1-yangx.jy@fujitsu.com> <20220106004005.GA2913243@nvidia.com> <2e708b1d-10d3-51ba-5da9-b05121e2cd89@linux.dev> <61DBC15E.5000402@fujitsu.com> <9e75da26-1339-36d4-1e30-83046b53e138@linux.dev> <744a7e96-6084-2977-69c3-fd0e35a0e99f@linux.dev> <61DE51D7.5050400@fujitsu.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yanjun Zhu In-Reply-To: <61DE51D7.5050400@fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org 在 2022/1/12 11:58, yangx.jy@fujitsu.com 写道: > On 2022/1/12 9:19, Yanjun Zhu wrote: >> 在 2022/1/11 23:16, Haakon Bugge 写道: >>>> On 11 Jan 2022, at 15:42, Yanjun Zhu wrote: >>>> >>>> >>>> 在 2022/1/10 13:17, yangx.jy@fujitsu.com 写道: >>>>> On 2022/1/7 19:49, Yanjun Zhu wrote: >>>>>> It seems that it does not mean to check the last packet. It means >>>>>> that >>>>>> it receives a MSN response. >>>>> Hi Yanjun, >>>>> >>>>> Checking the last packet is a way to indicate that responder has >>>>> completed an entire request(including multiple packets) and then >>>>> increases a msn. >>>> Hi, Xiao >>>> >>>> What does the msn mean? >>> Message Sequence Number. >> Thanks, Haakon >> >> I am reading the following from the spec. >> >> " >> >> C9-148: An HCA responder using Reliable Connection service shall >> initialize >> >> its MSN value to zero. The responder shall increment its MSN >> whenever it has successfully completed processing a new, valid request >> message. The MSN shall not be incremented for duplicate requests. The >> incremented MSN shall be returned in the last or only packet of an RDMA >> READ or Atomic response. For RDMA READ requests, the responder >> may increment its MSN after it has completed validating the request and >> before it has begun transmitting any of the requested data, and may >> return >> the incremented MSN in the AETH of the first response packet. The MSN >> shall be incremented only once for any given request message. >> >> " >> >> It seems that the above describe how to handle MSN increment in details. > Hi Yanjun, > > Sorry for the late reply. > > Right, 9.7.7.1 GENERATING MSN VALUE section explains Message Sequence Does your commit take into account of duplicate requests? Zhu Yanjun > Number(MSN). > > Best Regards, > Xiao Yang >> Zhu Yanjun >> >>> >>> Thxs, Håkon >>> >>>> Thanks a lot. >>>> >>>> Zhu Yanjun >>>> >>>>> Best Regards, >>>>> Xiao Yang