From: Jim Cromie <jim.cromie@gmail.com>
To: Linux kernel <linux-kernel@vger.kernel.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Coding style on function signatures (was: Convert tasklets to work queues )
Date: Sat, 07 Jul 2007 18:49:07 -0600 [thread overview]
Message-ID: <46903483.3020205@gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.98.0706231209130.3593@woody.linux-foundation.org>
Linus Torvalds wrote:
>
>
> Yes, code should be less than 80 characters wide.
>
> But hey, sometimes it's just more readable to have one line that is
> slightly longer than it should be, than to split something that is awkward
> to split.
>
>
< cc-list heavily trimmed >
could you speak to the specific case of function signatures ?
I saw nothing in CodingStyle specifically about this.
(I skimmed, and grepped for signature)
forex:
static ssize_t
store_fan_div (struct device *dev, struct device_attribute *devattr,
const char *buf, size_t count)
{...}
IIRC, many like the entire sig on one line, because its grep friendly.
I personally like the above, but grep-ability is hard to argue against.
The above has 2 violations (of strict-grep-ability rule)
1 - return sig is separate
2 - arg-list is split
next prev parent reply other threads:[~2007-07-08 0:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 18:20 [RFC PATCH 0/5 v2] Convert all tasklets to workqueues V2 Steven Rostedt
2007-06-22 18:20 ` [RFC PATCH 1/5 v2] Convert the RCU tasklet into a softirq Steven Rostedt
2007-06-22 22:53 ` Paul E. McKenney
2007-06-22 18:20 ` [RFC PATCH 2/5 v2] Split out tasklets from softirq.c Steven Rostedt
2007-06-22 18:20 ` [RFC PATCH 3/5 v2] Add a tasklet is-scheduled API Steven Rostedt
2007-06-22 18:20 ` [RFC PATCH 4/5 v2] Make DRM use the tasklet is-sched API Steven Rostedt
2007-06-22 18:20 ` [RFC PATCH 5/5 v2] Convert tasklets to work queues Steven Rostedt
2007-06-23 16:53 ` Andrew Morton
2007-06-23 18:00 ` Steven Rostedt
2007-06-23 18:19 ` Linus Torvalds
2007-06-23 18:52 ` Randy Dunlap
2007-06-23 18:58 ` Andrew Morton
2007-06-23 19:18 ` Linus Torvalds
2007-07-08 0:49 ` Jim Cromie [this message]
2007-07-08 4:37 ` Coding style on function signatures (was: Convert tasklets to work queues ) Randy Dunlap
2007-07-08 6:02 ` Oleg Verych
2007-07-08 10:12 ` Jan Engelhardt
2007-06-23 19:27 ` [RFC PATCH 5/5 v2] Convert tasklets to work queues Steven Rostedt
2007-06-23 19:39 ` Andrew Morton
2007-06-23 22:09 ` Linus Torvalds
2007-06-28 6:57 ` Jeff Garzik
2007-06-23 17:17 ` Oleg Nesterov
2007-06-23 21:15 ` [RFC PATCH 0/5 v2] Convert all tasklets to workqueues V2 Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46903483.3020205@gmail.com \
--to=jim.cromie@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.