From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Anatoly Burakov <anatoly.burakov@intel.com>,
David Hunt <david.hunt@intel.com>,
Sivaprasad Tummala <sivaprasad.tummala@amd.com>,
Tadhg Kearney <tadhg.kearney@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>
Subject: Re: [PATCH 1/2] power/intel_uncore: fix crash closing uninitialized driver
Date: Tue, 10 Jun 2025 09:07:12 +0200 [thread overview]
Message-ID: <4690957.tIAgqjz4sF@thomas> (raw)
In-Reply-To: <c4352c31-dbe1-4790-94b4-018a32628aba@intel.com>
21/05/2025 15:06, Kevin Laatz:
> On 15/05/2025 17:58, Bruce Richardson wrote:
> > When the power_intel_uncore_autotest unit test is run as an unprivileged
> > user which cannot init the power library, it crashes the unit test
> > binary due to calling "rte_power_uncore_exit" after the first test case
> > (initialization) fails. This crash is due to trying to write to NULL
> > file handles.
> >
> > Fix the crash by checking each file handle is non-null before writing to
> > it and closing it.
> >
> > Fixes: 60b8a661a957 ("power: add Intel uncore frequency control")
> > Cc:stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson<bruce.richardson@intel.com>
> >
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>
Series applied, thanks.
prev parent reply other threads:[~2025-06-10 7:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 16:58 [PATCH 1/2] power/intel_uncore: fix crash closing uninitialized driver Bruce Richardson
2025-05-15 16:58 ` [PATCH 2/2] test/power_intel_uncore: skip test if init fails Bruce Richardson
2025-05-21 13:06 ` Kevin Laatz
2025-05-21 13:06 ` [PATCH 1/2] power/intel_uncore: fix crash closing uninitialized driver Kevin Laatz
2025-06-10 7:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4690957.tIAgqjz4sF@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=sivaprasad.tummala@amd.com \
--cc=stable@dpdk.org \
--cc=tadhg.kearney@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.