From: Boaz Harrosh <bharrosh@panasas.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH] Is it time to kill ide-scsi.c?
Date: Sun, 08 Jul 2007 15:39:02 +0300 [thread overview]
Message-ID: <4690DAE6.8040404@panasas.com> (raw)
In-Reply-To: <468D83A8.2060804@garzik.org>
Jeff Garzik wrote:
> Boaz Harrosh wrote:
>> I have attempted (below) to convert ide-scsi to the new data
>> accessors and cleanup the !use_sg code paths. Inspecting
>> the code I can see places that still assume scsi_cmnd->request_buffer
>> is a linear char pointer. Though I admit this assumption is hidden
>> behind a flag "test_bit(PC_TRANSFORM, &pc->flags)". Is this an indication
>> that this drivers no longer works? What is needed in order to kill this
>> driver? If no killing is done than please accepted below patch.
>>
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>> ---
>> drivers/scsi/ide-scsi.c | 48 ++++++++++++++++++++++++++++------------------
>> 1 files changed, 29 insertions(+), 19 deletions(-)
>
> This is a very popular driver for some configurations. I know many
> people that used this for their ATAPI driver, rather than
> ide-{cdrom,floppy,...}
>
> Jeff
>
>
>
Two questions than
1. All these users, don't they have a new solution with PATA drivers
or that is only for new HW/chipsets?
2. Do you know who is the maintainer of this driver? Because if it is
still needed, than my patch must be accepted. And I think my added BUG()
only does it good.
Thanks
Boaz
prev parent reply other threads:[~2007-07-08 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 15:29 [PATCH] Is it time to kill ide-scsi.c? Boaz Harrosh
2007-07-05 23:50 ` Jeff Garzik
2007-07-08 12:39 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4690DAE6.8040404@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.