From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbXGHMmN (ORCPT ); Sun, 8 Jul 2007 08:42:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751415AbXGHMl7 (ORCPT ); Sun, 8 Jul 2007 08:41:59 -0400 Received: from il.qumranet.com ([82.166.9.18]:55130 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbXGHMl7 (ORCPT ); Sun, 8 Jul 2007 08:41:59 -0400 Message-ID: <4690DB9C.3010605@qumranet.com> Date: Sun, 08 Jul 2007 15:42:04 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Ingo Molnar CC: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Shaohua Li Subject: Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order References: <11838956891287-git-send-email-avi@qumranet.com> <1183895689306-git-send-email-avi@qumranet.com> <20070708122137.GB30226@elte.hu> In-Reply-To: <20070708122137.GB30226@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: > * Avi Kivity wrote: > > >> From: Shaohua Li >> >> Need to flush the tlb after updating a pte, not before. >> > > >> rmap_remove(vcpu, spte); >> - kvm_flush_remote_tlbs(vcpu->kvm); >> set_shadow_pte(spte, *spte & ~PT_WRITABLE_MASK); >> + kvm_flush_remote_tlbs(vcpu->kvm); >> > > hm, isnt this a must-have fix for v2.6.22 (and .21) as well? > Guest SMP support is only enabled by another patch in this patchset. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order Date: Sun, 08 Jul 2007 15:42:04 +0300 Message-ID: <4690DB9C.3010605@qumranet.com> References: <11838956891287-git-send-email-avi@qumranet.com> <1183895689306-git-send-email-avi@qumranet.com> <20070708122137.GB30226@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ingo Molnar Return-path: In-Reply-To: <20070708122137.GB30226-X9Un+BFzKDI@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Ingo Molnar wrote: > * Avi Kivity wrote: > > >> From: Shaohua Li >> >> Need to flush the tlb after updating a pte, not before. >> > > >> rmap_remove(vcpu, spte); >> - kvm_flush_remote_tlbs(vcpu->kvm); >> set_shadow_pte(spte, *spte & ~PT_WRITABLE_MASK); >> + kvm_flush_remote_tlbs(vcpu->kvm); >> > > hm, isnt this a must-have fix for v2.6.22 (and .21) as well? > Guest SMP support is only enabled by another patch in this patchset. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/