Re: [PATCH] stex: use resid for xfer len information

[Boaz Harrosh <bharrosh@panasas.com>]

Ed Lin wrote:
> The original implementation in stex_ys_commands() is inappropriate.
> For xfer len information, we should use resid instead.
> 
> Signed-off-by: Ed Lin <ed.lin@promise.com>
> ---
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index adda296..72f6d80 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -719,8 +719,8 @@ static void stex_ys_commands(struct st_h
>  
>  	if (ccb->cmd->cmnd[0] == MGT_CMD &&
>  		resp->scsi_status != SAM_STAT_CHECK_CONDITION) {
> -		scsi_bufflen(ccb->cmd) =
> -			le32_to_cpu(*(__le32 *)&resp->variable[0]);
> +		scsi_set_resid(ccb->cmd, scsi_bufflen(ccb->cmd) -
> +			le32_to_cpu(*(__le32 *)&resp->variable[0]));
>  		return;
>  	}
>  
> 
> 
> -

Thanks Ed Lin

This looks perfect to me. I was hoping for such a solution.
Thank you for looking into it.

Boaz