From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756452AbXGIJqf (ORCPT ); Mon, 9 Jul 2007 05:46:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751667AbXGIJqM (ORCPT ); Mon, 9 Jul 2007 05:46:12 -0400 Received: from il.qumranet.com ([82.166.9.18]:46750 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbXGIJqL (ORCPT ); Mon, 9 Jul 2007 05:46:11 -0400 Message-ID: <469203E9.7000109@qumranet.com> Date: Mon, 09 Jul 2007 12:46:17 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Shaohua Li CC: kvm-devel@lists.sourceforge.net, Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH][RFC] kvm-scheduler integration References: <11838994974161-git-send-email-avi@qumranet.com> <1183971001.4254.3.camel@sli10-conroe.sh.intel.com> In-Reply-To: <1183971001.4254.3.camel@sli10-conroe.sh.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Shaohua Li wrote: > On Sun, 2007-07-08 at 20:58 +0800, Avi Kivity wrote: > >> The only fly in the ointment is that it crashes quite soon. Haven't >> figured >> out why yet, but comments on the general direction would be welcome. >> > Attached patch seems help in my test. prepare_task_switch is called with > irq disabled. > > > Thanks!! Will integrate that. >> -static void vmx_vcpu_load(struct kvm_vcpu *vcpu) >> +static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) >> { >> u64 phys_addr = __pa(vcpu->vmcs); >> - int cpu; >> u64 tsc_this, delta; >> >> - cpu = get_cpu(); >> - >> + WARN_ON(!preempt_count()); >> > This and below change will break preempt disabled case. better remove > them. > Right. Will take them out. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][RFC] kvm-scheduler integration Date: Mon, 09 Jul 2007 12:46:17 +0300 Message-ID: <469203E9.7000109@qumranet.com> References: <11838994974161-git-send-email-avi@qumranet.com> <1183971001.4254.3.camel@sli10-conroe.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shaohua Li Return-path: In-Reply-To: <1183971001.4254.3.camel-yAZKuqJtXNMXR+D7ky4Foa2pdiUAq4bhAL8bYrjMMd8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Shaohua Li wrote: > On Sun, 2007-07-08 at 20:58 +0800, Avi Kivity wrote: > >> The only fly in the ointment is that it crashes quite soon. Haven't >> figured >> out why yet, but comments on the general direction would be welcome. >> > Attached patch seems help in my test. prepare_task_switch is called with > irq disabled. > > > Thanks!! Will integrate that. >> -static void vmx_vcpu_load(struct kvm_vcpu *vcpu) >> +static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) >> { >> u64 phys_addr = __pa(vcpu->vmcs); >> - int cpu; >> u64 tsc_this, delta; >> >> - cpu = get_cpu(); >> - >> + WARN_ON(!preempt_count()); >> > This and below change will break preempt disabled case. better remove > them. > Right. Will take them out. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/