All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Sealey <matt@genesi-usa.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: CHRP PCI fixup for Pegasos IDE (looking for testers)
Date: Mon, 09 Jul 2007 17:45:01 +0100	[thread overview]
Message-ID: <4692660D.3050807@genesi-usa.com> (raw)
In-Reply-To: <20070709174325.7cb19968@the-village.bc.nu>

Fixed the define thing.

As a corollary to the patch it might be a good idea to fix the
arch/powerpc/kernel/prom_init.c at line ~2084 and remove the
interrupt 15 reference

		prop[0] = 14;
		prop[1] = 0x0;
-		prop[0] = 15;
-		prop[1] = 0x0;
-		prom_setprop(ph, name, "interrupts", prop, 4*sizeof(u32));
+		prom_setprop(ph, name, "interrupts", prop, 2*sizeof(u32));
	}
}

Since nobody uses the device tree for anything here, I think
it's merely cosmetic, though.

I'll see what I can do about getting this fix into the firmware
as and if the via86cxxx driver works with it (I have my doubts but
am willing to be pleasantly surprised)

-- 
Matt Sealey <matt@genesi-usa.com>
Genesi, Manager, Developer Relations

Alan Cox wrote:
>> I don't understand what you mean by the ifdef being wrong. I don't
>> see how else I can make any kind of check for it. If the fix needs
> 
> if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE)
> 
>> The viaide->irq check is just me being careful. I know for a fact the
>> only way the Pegasos is set up on every firmware revision is that
>> the PCI interrupt line for the IDE controller is set to 14. If it's
> 
> Cool. Thats fine then.

      reply	other threads:[~2007-07-09 16:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-09 14:54 CHRP PCI fixup for Pegasos IDE (looking for testers) Matt Sealey
2007-07-09 15:00 ` Matt Sealey
2007-07-09 15:06 ` Alan Cox
2007-07-09 16:05   ` Matt Sealey
2007-07-09 16:43     ` Alan Cox
2007-07-09 16:45       ` Matt Sealey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4692660D.3050807@genesi-usa.com \
    --to=matt@genesi-usa.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.