All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Fix QEMU target detection
Date: Tue, 10 Jul 2007 11:11:56 +0300	[thread overview]
Message-ID: <46933F4C.2080008@qumranet.com> (raw)
In-Reply-To: <1184002527532-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Anthony Liguori wrote:
> This looks like a typo.  I think the intention of the if is to normalize
> i[3456]86 to i386 since that's the target name for QEMU.
>
> Signed-off-by: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/configure b/configure
> index d9292fe..e4d1ec6 100755
> --- a/configure
> +++ b/configure
> @@ -74,7 +74,7 @@ fi
>  
>  target_cpu() {
>      if [[ $(uname -m) = i?86 ]]; then
> -	echo x86_64
> +	echo i386
>      else
>  	uname -m
>      fi
>   

This is intentional.  It allows migration from 32-bit hosts to 64-bit 
hosts.  Another side effect is that 64-bit guests can be run on 64-bit 
hosts with 32-bit userspace.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-07-10  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-09 17:35 [PATCH] Fix QEMU target detection Anthony Liguori
     [not found] ` <1184002527532-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-07-10  8:11   ` Avi Kivity [this message]
     [not found]     ` <46933F4C.2080008-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-12  2:49       ` Jun Koi
     [not found]         ` <fdaac4d50707111949r41205f12v4b6bef4da1553dbd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-13  8:08           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46933F4C.2080008@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.