From: Jan Dittmer <jdi@l4x.org>
To: mingo@elte.hu
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: sched: rename idle_type/SCHED_IDLE
Date: Tue, 10 Jul 2007 15:02:27 +0200 [thread overview]
Message-ID: <46938363.2000007@l4x.org> (raw)
In-Reply-To: <200707092059.l69Kx1kb026264@hera.kernel.org>
Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d15bcfdbe1818478891d714343f037cfe60875f0
> Commit: d15bcfdbe1818478891d714343f037cfe60875f0
> Parent: 7dcca30a32aadb0520417521b0c44f42d09fe05c
> Author: Ingo Molnar <mingo@elte.hu>
> AuthorDate: Mon Jul 9 18:51:57 2007 +0200
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Mon Jul 9 18:51:57 2007 +0200
>
> sched: rename idle_type/SCHED_IDLE
>
> enum idle_type (used by the load-balancer) clashes with the
> SCHED_IDLE name that we want to introduce. 'CPU_IDLE' instead
> of 'SCHED_IDLE' is more descriptive as well.
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -639,12 +639,11 @@ static inline int sched_info_on(void)
> #endif
> }
>
> -enum idle_type
> -{
> - SCHED_IDLE,
> - NOT_IDLE,
> - NEWLY_IDLE,
> - MAX_IDLE_TYPES
> +enum cpu_idle_type {
> + CPU_IDLE,
> + CPU_NOT_IDLE,
> + CPU_NEWLY_IDLE,
> + CPU_MAX_IDLE_TYPES
> };
>
> /*
This broke s390:
GEN /tmp/tmp.qnrRZ13800/out/s390/Makefile
CHK include/linux/version.h
UPD include/linux/version.h
CHK include/linux/utsrelease.h
UPD include/linux/utsrelease.h
SYMLINK include/asm -> include/asm-s390
CC arch/s390/kernel/asm-offsets.s
In file included from
/tmp/tmp.qnrRZ13800/kernel/arch/s390/kernel/asm-offsets.c:7:
/tmp/tmp.qnrRZ13800/kernel/include/linux/sched.h:641: error: syntax
error before numeric constant
make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
make[1]: *** [prepare0] Error 2
make: *** [_all] Error 2
CLEAN .tmp_versions
Jan
next parent reply other threads:[~2007-07-10 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200707092059.l69Kx1kb026264@hera.kernel.org>
2007-07-10 13:02 ` Jan Dittmer [this message]
2007-07-10 21:11 ` sched: rename idle_type/SCHED_IDLE Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46938363.2000007@l4x.org \
--to=jdi@l4x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.