Re: [PATCH] spidernet: improve interrupt handling

[Jeff Garzik <jeff@garzik.org>]

Linas Vepstas wrote:
> From: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
> 
> We intend this patch to improve spidernet interrupt handling to be
> more strict.  We had following problem and this patch solves it.
> 
>  -when CONFIG_DEBUG_SHIRQ=y, request_irq() calls handler().
>  -when spider_net_open() is called, it calls request_irq() which calls
>   spider_net_interrupt().
>  -if some specific interrupt bit is set at this timing, it calls
>   netif_rx_schedule() and spider_net_poll() is scheduled.
>  -spider_net_open() calls netif_poll_enable() which clears the bit 
>   __LINK_STATE_RX_SCHED.
>  -when spider_net_poll() is called, it calls netif_rx_complete() which
>   causes BUG_ON() because __LINK_STATE_RX_SCHED is not set.
> 
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
> 
> ----
> Jeff, please apply for 2.6.23
> 
> Linas.
> 
>  drivers/net/spider_net.c |   59 +++++++++++++++++++++++++++++++++++------------
>  1 file changed, 45 insertions(+), 14 deletions(-)
> 

applied