Re: [PATCH] Cleanup usbnet_probe() return value handling

[Jeff Garzik <jeff@garzik.org>]

Peter Korsgaard wrote:
>>>>>> "David" == David Brownell <david-b@pacbell.net> writes:
> 
> Hi,
> 
>  David> I'd rather see the later test updated to match this one.
>  David> (Good catch!)
> 
>  David> The return convention is "negative means error".  There's
>  David> code in USB which has multiple nonnegative success codes.
> 
> Ok, updated patch does that instead.
> 
>  David> In particular usb_control_msg(), which would very naturally
>  David> used as the body of a bind() method, returns negative or
>  David> the number of bytes transferred.
> 
> Yeah, that was the original problem in my dm9601 driver.
> 
> usbnet_probe() handles a positive return value from the driver bind()
> function as success, but will later only setup the status handler if the
> return value was zero, leading to confusion. Patch adjusts this to accept
> positive values as success in both checks.
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
>  drivers/net/usb/usbnet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied