From: Peter Watkins <pwatkins@sicortex.com>
To: linux-mips@linux-mips.org
Cc: Peter Watkins <pwatkins@sicortex.com>
Subject: start_secondary flushing remote icaches?
Date: Tue, 10 Jul 2007 14:07:59 -0400 [thread overview]
Message-ID: <4693CAFF.6000101@sicortex.com> (raw)
Greetings,
I'm updating our port to 2.6.22 and I notice that r4k_flush_icache_range
no longer has a check for irqs_disabled (to force local-only flush).
This hits the BUG_ON(!cpu_online(cpu)) assertion in smp_call_function
since cpu's aren't marked online until after start_secondary:
Call Trace:
[<ffffffff8010d394>] smp_call_function+0x84/0x1f0
[<ffffffff8011dec0>] r4k_flush_icache_range+0x28/0x48
[<ffffffff80434a4c>] r4k_cache_init+0x6dc/0x1070
[<ffffffff8042fca0>] per_cpu_trap_init+0x180/0x288
[<ffffffff804304b4>] start_secondary+0x24/0x118
[<ffffffff80101c40>] prom_smp_bootstrap+0x10/0x50
So, the question is, how should the remote icache flush be avoided in
this case?
-p
reply other threads:[~2007-07-10 18:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4693CAFF.6000101@sicortex.com \
--to=pwatkins@sicortex.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.