Re: [PATCH] ps3: gigabit ethernet driver for PS3, take3

[Jeff Garzik <jeff@garzik.org>]

Masakazu Mokuno wrote:
> Hi, 
> 
> This is the third submission of the network driver for PS3.
> The differences from the previous one are:
> 
>   - renamed source file names so that their prefix can match
>     with the module name
>   - added cbe-oss-dev@ozlabs.org line for MAINTAINER file
>   - changed some in copyright comments
>   
> If there are no more comments, please apply for 2.6.23. 
> 
> Thank you
> 
> --
> Subject: PS3: Ethernet driver
> 
> From: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> 
> Add Gigabit Ethernet support for the PS3 game console.  The module will
> be called ps3_gelic.
> 
> CC: Geoff Levand <geoffrey.levand@am.sony.com>
> Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> ---
>  MAINTAINERS                 |    7 
>  drivers/net/Kconfig         |   10 
>  drivers/net/Makefile        |    2 
>  drivers/net/ps3_gelic_net.c | 1576 ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/ps3_gelic_net.h |  239 ++++++
>  5 files changed, 1834 insertions(+)

applied

I request that you fix the NETDEV_TX_LOCKED return value on error in 
->hard_start_xmit(), which appears to be an incorrect return value for 
that condition, for your driver

	Jeff