Re: Linux 2.6.22 released

[Chuck Ebbert <cebbert@redhat.com>]

On 07/09/2007 06:14 AM, Alan Cox wrote:
> Are the shortlogs useful - yes .. they catch what appear to be mistakes
> 
> Specifically: What happened to the aacraid ioctl security fix ? Did someone decide it
> wasn't needed or did it get lost somewhere on the way ?
> 
> While this looks scary the only obvious exploit cases are where the user can
> open a device level file on an AACraid. Very few people put scanners or CD
> devices on one so the actual impact is probably minimal.

I can't find that patch in any SCSI git tree.

> --- drivers/scsi/aacraid/linit.c~	2007-07-09 10:51:55.653223304 +0100
> +++ drivers/scsi/aacraid/linit.c	2007-07-09 10:51:55.653223304 +0100
> @@ -453,6 +453,8 @@
>  static int aac_ioctl(struct scsi_device *sdev, int cmd, void __user * arg)
>  {
>  	struct aac_dev *dev = (struct aac_dev *)sdev->host->hostdata;
> +	if (!capable(CAP_SYS_RAWIO))
> +		return -EPERM;