From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH libata-dev#upstream] libata: simplify PCI legacy SFF host handling
Date: Tue, 10 Jul 2007 21:38:03 -0400 [thread overview]
Message-ID: <4694347B.2030700@garzik.org> (raw)
In-Reply-To: <468B620F.3010603@gmail.com>
Tejun Heo wrote:
> With PCI resource fix up for legacy hosts. We can use the same code
> path to allocate IO resources and initialize host for both legacy and
> native SFF hosts. Only IRQ requesting needs to be different.
>
> Rename ata_pci_*_native_host() to ata_pci_*_sff_host(), kill all
> legacy specific functions and use the renamed functions instead. This
> simplifies code a lot.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> ---
> Gee, I like it. The BAR fixup thing was a really good idea. :-)
>
> drivers/ata/libata-core.c | 4
> drivers/ata/libata-sff.c | 288 +++++-----------------------------------------
> drivers/ata/sata_nv.c | 2
> drivers/ata/sata_sis.c | 2
> drivers/ata/sata_uli.c | 2
> drivers/ata/sata_via.c | 2
> include/linux/libata.h | 8 -
> 7 files changed, 42 insertions(+), 266 deletions(-)
applied
prev parent reply other threads:[~2007-07-11 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 9:02 [PATCH libata-dev#upstream] libata: simplify PCI legacy SFF host handling Tejun Heo
2007-07-04 9:39 ` Alan Cox
2007-07-11 1:38 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4694347B.2030700@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.